Generalize Google Voice sender config - #81
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c8268d216
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "CRISIS_ALERT_SMTP_SSL" | ||
| ) | ||
| remove_secret_vars=("CRISIS_ALERT_SMTP_PASSWORD") | ||
| remove_secret_vars=("CRISIS_ALERT_SMTP_PASSWORD" "CRISIS_ALERT_GOOGLE_VOICE_GMAIL_APP_PASSWORD") |
There was a problem hiding this comment.
When a repo is still configured with CRISIS_ALERT_GOOGLE_VOICE_GMAIL_APP_PASSWORD/..._SECRET_NAME and has not yet added the new CRISIS_ALERT_GOOGLE_VOICE_SENDER_PASSWORD* settings, this workflow now removes the old Cloud Run secret binding unconditionally but never re-adds an equivalent value under the new name. In that migration state, the sync job succeeds yet Google Voice alert sending loses its SMTP credential on the next deploy, causing production alert delivery to stop silently.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests